Fixes #7391 - fixing error in rad group show for no args by superbeeny · Pull Request #7852 · radius-project/radius

superbeeny · 2024-08-28T15:41:47Z

Description

Fixes #7391 - fixes issue with error incorrectly returned for rad group show with no group name argument.

Type of change

This pull request fixes a bug in Radius and has an approved issue (issue link required).

Fixes: #7391

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

rynowak · 2024-08-28T15:42:29Z

/cc @nithyatsu - can you help review?

radius-functional-tests · 2024-08-28T15:48:23Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`5969e9b`
Unique ID	funcf0780400ed
Image tag	pr-funcf0780400ed

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcf0780400ed
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcf0780400ed
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcf0780400ed
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcf0780400ed
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
❌ corerp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test cancelled. Please check the logs for more details
❌ datastoresrp-cloud functional test cancelled. Please check the logs for more details
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded
❌ corerp-cloud functional test failed. Please check the logs for more details

codecov · 2024-08-28T15:54:09Z

Codecov Report

Attention: Patch coverage is 11.76471% with 15 lines in your changes missing coverage. Please review.

Project coverage is 61.13%. Comparing base (3ddb61e) to head (b46ccef).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/cli/clivalidation.go	0.00%	15 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7852      +/-   ##
==========================================
- Coverage   61.17%   61.13%   -0.05%     
==========================================
  Files         523      523              
  Lines       27588    27603      +15     
==========================================
- Hits        16877    16875       -2     
- Misses       9223     9239      +16     
- Partials     1488     1489       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rynowak · 2024-08-28T16:57:34Z

Functional test failure is unrelated, and seems to be impacting all of our runs. We're investigating offline.

nithyatsu · 2024-08-28T20:03:43Z

Thank you so much for contributing to Radius, Nick! I left a couple of comments.

radius-functional-tests · 2024-09-03T20:31:44Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`a5a9f5f`
Unique ID	funcceb5c9e249
Image tag	pr-funcceb5c9e249

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcceb5c9e249
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcceb5c9e249
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcceb5c9e249
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcceb5c9e249
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
⌛ Starting ucp-cloud functional tests...
✅ datastoresrp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

radius-functional-tests · 2024-09-04T15:46:45Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`b46ccef`
Unique ID	funca8b754b7a3
Image tag	pr-funca8b754b7a3

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funca8b754b7a3
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funca8b754b7a3
controller test image location: ghcr.io/radius-project/dev/controller:pr-funca8b754b7a3
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funca8b754b7a3
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ datastoresrp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Fixes radius-project#7391 - fixing error in rad group show for no args

5c7cbba

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

superbeeny requested review from a team as code owners August 28, 2024 15:41

Merge branch 'main' into superbeeny/issue7391

5969e9b

superbeeny temporarily deployed to functional-tests August 28, 2024 15:47 — with GitHub Actions Inactive

nithyatsu reviewed Aug 28, 2024

View reviewed changes

Comment thread pkg/cli/cmd/group/show/show.go Outdated

nithyatsu reviewed Aug 28, 2024

View reviewed changes

Comment thread pkg/cli/cmd/group/show/show.go Outdated

superbeeny added 2 commits September 3, 2024 14:19

Merge branch 'radius-project:main' into superbeeny/issue7391

5c92124

Merge branch 'main' into superbeeny/issue7391

a5a9f5f

superbeeny temporarily deployed to functional-tests September 3, 2024 20:30 — with GitHub Actions Inactive

resolving comments and feedback, moving validation to clivalidation

b46ccef

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

superbeeny requested a review from nithyatsu September 4, 2024 14:34

rynowak approved these changes Sep 4, 2024

View reviewed changes

superbeeny temporarily deployed to functional-tests September 4, 2024 15:45 — with GitHub Actions Inactive

ytimocin approved these changes Sep 4, 2024

View reviewed changes

nithyatsu approved these changes Sep 4, 2024

View reviewed changes

lakshmimsft merged commit 5366a82 into radius-project:main Sep 4, 2024

superbeeny mentioned this pull request Jan 29, 2025

REQUEST: Approver for superbeeny radius-project/community#76

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #7391 - fixing error in rad group show for no args#7852

Fixes #7391 - fixing error in rad group show for no args#7852
lakshmimsft merged 5 commits into
radius-project:mainfrom
superbeeny:superbeeny/issue7391

superbeeny commented Aug 28, 2024

Uh oh!

rynowak commented Aug 28, 2024

Uh oh!

radius-functional-tests Bot commented Aug 28, 2024 •

edited

Loading

Uh oh!

codecov Bot commented Aug 28, 2024 •

edited

Loading

Uh oh!

rynowak commented Aug 28, 2024

Uh oh!

Uh oh!

Uh oh!

nithyatsu commented Aug 28, 2024

Uh oh!

radius-functional-tests Bot commented Sep 3, 2024 •

edited

Loading

Uh oh!

radius-functional-tests Bot commented Sep 4, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

superbeeny commented Aug 28, 2024

Description

Type of change

Uh oh!

rynowak commented Aug 28, 2024

Uh oh!

radius-functional-tests Bot commented Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

codecov Bot commented Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rynowak commented Aug 28, 2024

Uh oh!

Uh oh!

Uh oh!

nithyatsu commented Aug 28, 2024

Uh oh!

radius-functional-tests Bot commented Sep 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

radius-functional-tests Bot commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

radius-functional-tests Bot commented Aug 28, 2024 •

edited

Loading

codecov Bot commented Aug 28, 2024 •

edited

Loading

radius-functional-tests Bot commented Sep 3, 2024 •

edited

Loading

radius-functional-tests Bot commented Sep 4, 2024 •

edited

Loading