[UDT] add create resource type command by nithyatsu · Pull Request #8104 · radius-project/radius

nithyatsu · 2024-12-03T20:42:41Z

Description

add rad resource-type create

Type of change

This pull request adds or changes features of Radius and has an approved issue (issue link required).

Partially Fixes: #issue_number

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

[ NA] An overview of proposed schema changes is included in a linked GitHub issue.
[ NA] A design document PR is created in the design-notes repository, if new APIs are being introduced.
[NA ] If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
[NA ] A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
[ NA] A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
[ NA] A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

codecov · 2025-01-03T21:20:57Z

Codecov Report

Attention: Patch coverage is 35.29412% with 176 lines in your changes missing coverage. Please review.

Project coverage is 59.75%. Comparing base (3c28b26) to head (c6eb041).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/cli/manifest/testclientfactory.go	27.36%	68 Missing and 1 partial ⚠️
pkg/cli/manifest/registermanifest.go	0.00%	54 Missing ⚠️
pkg/cli/cmd/resourcetype/create/create.go	64.22%	31 Missing and 8 partials ⚠️
pkg/cli/clivalidation.go	0.00%	14 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8104      +/-   ##
==========================================
- Coverage   59.94%   59.75%   -0.19%     
==========================================
  Files         589      590       +1     
  Lines       39237    39487     +250     
==========================================
+ Hits        23519    23597      +78     
- Misses      13981    14146     +165     
- Partials     1737     1744       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

radius-functional-tests · 2025-01-06T23:26:32Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`8b5d45f`
Unique ID	func00e91324c4
Image tag	pr-func00e91324c4

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func00e91324c4
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func00e91324c4
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func00e91324c4
controller test image location: ghcr.io/radius-project/dev/controller:pr-func00e91324c4
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func00e91324c4
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

radius-functional-tests · 2025-01-06T23:59:10Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`492c575`
Unique ID	funcb2077b2908
Image tag	pr-funcb2077b2908

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcb2077b2908
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcb2077b2908
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcb2077b2908
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcb2077b2908
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcb2077b2908
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

radius-functional-tests · 2025-01-07T18:54:48Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`76430a0`
Unique ID	funcd265900b33
Image tag	pr-funcd265900b33

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcd265900b33
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcd265900b33
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcd265900b33
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcd265900b33
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcd265900b33
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

radius-functional-tests · 2025-01-07T19:07:32Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`ed3c9d7`
Unique ID	func30c68be944
Image tag	pr-func30c68be944

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func30c68be944
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func30c68be944
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func30c68be944
controller test image location: ghcr.io/radius-project/dev/controller:pr-func30c68be944
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func30c68be944
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

ytimocin · 2025-01-07T22:18:34Z

+
+	// If resource provider does not exist or if there is any other error, first register the resource provider.
+	response, err := r.UCPClientFactory.NewResourceProvidersClient().Get(ctx, "local", r.ResourceProvider.Name, nil)
+	if err != nil {


The error can also be something other than Resource Provider not Found, right?

yes. Currently, if there are errors, approach is to recreate. @rynowak do you see any problems with this approach?

I think we should only create if the error is 404 and fail if it is something else.

Added changes to return error if it is not 404.

I think we should only create if the error is 404 and fail if it is something else.

Added changes to return error if it is not 404.

ytimocin · 2025-01-08T18:23:20Z

+
+	// If resource provider does not exist or if there is any other error, first register the resource provider.
+	response, err := r.UCPClientFactory.NewResourceProvidersClient().Get(ctx, "local", r.ResourceProvider.Name, nil)
+	if err != nil {


I think we should only create if the error is 404 and fail if it is something else.

… case to capture the flow.

radius-functional-tests · 2025-01-08T22:02:33Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`1469009`
Unique ID	funcc4e12f819f
Image tag	pr-funcc4e12f819f

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcc4e12f819f
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcc4e12f819f
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcc4e12f819f
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcc4e12f819f
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcc4e12f819f
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

ytimocin · 2025-01-08T22:03:31Z

+		return err
+	}
+
+	// get the existing location resource and update it with new resource type. We have to revisit this code once schema is finalized and validated.


nit: remove

I think this comment is useful because it indicates revisiting the code once schema validation comes in.

radius-functional-tests · 2025-01-08T23:03:28Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`c6eb041`
Unique ID	funcb6e3034473
Image tag	pr-funcb6e3034473

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcb6e3034473
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcb6e3034473
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcb6e3034473
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcb6e3034473
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcb6e3034473
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

nithyatsu temporarily deployed to publish-bicep December 3, 2024 20:42 — with GitHub Actions Inactive

nithyatsu changed the title ~~add create resource type command~~ [UDT] add create resource type command Dec 5, 2024

nithyatsu had a problem deploying to functional-tests January 2, 2025 20:42 — with GitHub Actions Failure

nithyatsu force-pushed the udt_rt_create branch from b81faec to 4c00940 Compare January 3, 2025 21:04

nithyatsu temporarily deployed to publish-bicep January 3, 2025 21:05 — with GitHub Actions Inactive

nithyatsu temporarily deployed to publish-bicep January 6, 2025 21:05 — with GitHub Actions Inactive

nithyatsu force-pushed the udt_rt_create branch from 09246ab to 8b5d45f Compare January 6, 2025 23:22

nithyatsu temporarily deployed to publish-bicep January 6, 2025 23:22 — with GitHub Actions Inactive

nithyatsu temporarily deployed to functional-tests January 6, 2025 23:25 — with GitHub Actions Inactive

nithyatsu temporarily deployed to publish-bicep January 6, 2025 23:57 — with GitHub Actions Inactive

nithyatsu marked this pull request as ready for review January 6, 2025 23:57

nithyatsu requested review from a team as code owners January 6, 2025 23:57

nithyatsu temporarily deployed to functional-tests January 6, 2025 23:58 — with GitHub Actions Inactive

ytimocin requested changes Jan 7, 2025

View reviewed changes

nithyatsu force-pushed the udt_rt_create branch from 492c575 to 76430a0 Compare January 7, 2025 18:49

nithyatsu temporarily deployed to publish-bicep January 7, 2025 18:49 — with GitHub Actions Inactive

nithyatsu temporarily deployed to functional-tests January 7, 2025 18:53 — with GitHub Actions Inactive

nithyatsu temporarily deployed to publish-bicep January 7, 2025 19:05 — with GitHub Actions Inactive

nithyatsu temporarily deployed to functional-tests January 7, 2025 19:06 — with GitHub Actions Inactive

nithyatsu requested a review from ytimocin January 7, 2025 21:57

ytimocin reviewed Jan 7, 2025

View reviewed changes

ytimocin reviewed Jan 8, 2025

View reviewed changes

nithyatsu temporarily deployed to publish-bicep January 8, 2025 21:16 — with GitHub Actions Inactive

add create resource type command

51066ca

nithyatsu added 8 commits January 8, 2025 13:23

add a registerType function

68c2767

add create resource-type

657ed95

add a test and refactor

019d77d

add test

5f2362a

update comments

e42745a

revert local changes to launch.json

8383d45

add logic to differentiate between 404 errors and the other. Add test…

e4d9b42

… case to capture the flow.

nit

1469009

nithyatsu force-pushed the udt_rt_create branch from 55a1c0d to 1469009 Compare January 8, 2025 21:23

nithyatsu requested a review from ytimocin January 8, 2025 21:23

nithyatsu temporarily deployed to publish-bicep January 8, 2025 21:24 — with GitHub Actions Inactive

nithyatsu temporarily deployed to functional-tests January 8, 2025 22:01 — with GitHub Actions Inactive

ytimocin previously approved these changes Jan 8, 2025

View reviewed changes

ytimocin reviewed Jan 8, 2025

View reviewed changes

lakshmimsft reviewed Jan 8, 2025

View reviewed changes

Comment thread pkg/cli/manifest/testclientfactory.go

lakshmimsft reviewed Jan 8, 2025

View reviewed changes

Comment thread pkg/cli/manifest/registermanifest.go Outdated

lakshmimsft reviewed Jan 8, 2025

View reviewed changes

Comment thread pkg/cli/manifest/registermanifest.go

remove some comments and add a const.

c6eb041

nithyatsu dismissed ytimocin’s stale review via c6eb041 January 8, 2025 23:00

nithyatsu temporarily deployed to publish-bicep January 8, 2025 23:00 — with GitHub Actions Inactive

lakshmimsft approved these changes Jan 8, 2025

View reviewed changes

nithyatsu temporarily deployed to functional-tests January 8, 2025 23:02 — with GitHub Actions Inactive

nithyatsu merged commit 73ed52d into radius-project:main Jan 8, 2025

kachawla mentioned this pull request Feb 6, 2025

release 0.43.0 #8416

Merged

12 tasks

Conversation

nithyatsu commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Contributor checklist

Uh oh!

codecov Bot commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

radius-functional-tests Bot commented Jan 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

radius-functional-tests Bot commented Jan 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

radius-functional-tests Bot commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

radius-functional-tests Bot commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

radius-functional-tests Bot commented Jan 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

radius-functional-tests Bot commented Jan 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

nithyatsu commented Dec 3, 2024 •

edited

Loading

codecov Bot commented Jan 3, 2025 •

edited

Loading

radius-functional-tests Bot commented Jan 6, 2025 •

edited

Loading

radius-functional-tests Bot commented Jan 6, 2025 •

edited

Loading

radius-functional-tests Bot commented Jan 7, 2025 •

edited

Loading

radius-functional-tests Bot commented Jan 7, 2025 •

edited

Loading

radius-functional-tests Bot commented Jan 8, 2025 •

edited

Loading

radius-functional-tests Bot commented Jan 8, 2025 •

edited

Loading