fixing issue with deployment to AKS by superbeeny · Pull Request #8249 · radius-project/radius

superbeeny · 2025-01-15T20:58:24Z

Description

Set the storageClass to an empty string to pick up the default storage class
Defined the mountPoint for the pvc.

Type of change

This pull request adds or changes features of Radius and has an approved issue (issue link required).

Fixes: #8072

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
A design document PR is created in the design-notes repository, if new APIs are being introduced.
If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

Signed-off-by: Nick Beenham <Nicholas_Beenham@cable.comcast.com>

radius-functional-tests · 2025-01-15T21:01:08Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`2284f12`
Unique ID	func2d3b4cd82a
Image tag	pr-func2d3b4cd82a

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func2d3b4cd82a
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func2d3b4cd82a
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func2d3b4cd82a
controller test image location: ghcr.io/radius-project/dev/controller:pr-func2d3b4cd82a
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func2d3b4cd82a
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ Failed to install Radius for corerp-cloud functional test. Please check the logs for more details
❌ corerp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test cancelled. Please check the logs for more details
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
❌ Failed to install Radius for ucp-cloud functional test. Please check the logs for more details
❌ Failed to install Radius for corerp-cloud functional test. Please check the logs for more details
❌ ucp-cloud functional test failed. Please check the logs for more details
❌ corerp-cloud functional test failed. Please check the logs for more details

codecov · 2025-01-15T21:09:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.81%. Comparing base (a665232) to head (c2a7d4b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8249      +/-   ##
==========================================
- Coverage   59.83%   59.81%   -0.02%     
==========================================
  Files         590      590              
  Lines       39520    39520              
==========================================
- Hits        23646    23640       -6     
- Misses      14119    14123       +4     
- Partials     1755     1757       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Nick Beenham <Nicholas_Beenham@cable.comcast.com>

radius-functional-tests · 2025-01-16T14:00:53Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`f265c79`
Unique ID	funcb98719bfc7
Image tag	pr-funcb98719bfc7

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcb98719bfc7
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcb98719bfc7
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcb98719bfc7
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcb98719bfc7
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcb98719bfc7
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

kachawla

Looks good. One minor comment.

kachawla · 2025-01-21T18:32:07Z

+database:
+  image: ghcr.io/radius-project/mirror/postgres
+  tag: latest
+  storageClassName: "" # set to the storage class name if required


Could you please add a comment here what does setting it to empty do?

will do in my next commit :)

radius-functional-tests · 2025-01-21T19:07:06Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`dc10ea9`
Unique ID	func9e1aad02c9
Image tag	pr-func9e1aad02c9

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func9e1aad02c9
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func9e1aad02c9
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func9e1aad02c9
controller test image location: ghcr.io/radius-project/dev/controller:pr-func9e1aad02c9
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func9e1aad02c9
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ Failed to install Radius for corerp-cloud functional test. Please check the logs for more details
❌ corerp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test cancelled. Please check the logs for more details
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ Failed to install Radius for corerp-cloud functional test. Please check the logs for more details
❌ corerp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test cancelled. Please check the logs for more details
⌛ Starting corerp-cloud functional tests...
❌ Failed to install Radius for corerp-cloud functional test. Please check the logs for more details
❌ corerp-cloud functional test failed. Please check the logs for more details
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ Failed to install Radius for ucp-cloud functional test. Please check the logs for more details
❌ ucp-cloud functional test failed. Please check the logs for more details
❌ corerp-cloud functional test cancelled. Please check the logs for more details

radius-functional-tests · 2025-01-22T14:26:44Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`c2a7d4b`
Unique ID	funcfa8ae400ea
Image tag	pr-funcfa8ae400ea

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcfa8ae400ea
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcfa8ae400ea
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcfa8ae400ea
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcfa8ae400ea
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcfa8ae400ea
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

fixing issue with deployment to AKS

2284f12

Signed-off-by: Nick Beenham <Nicholas_Beenham@cable.comcast.com>

superbeeny requested review from a team as code owners January 15, 2025 20:58

superbeeny temporarily deployed to publish-bicep January 15, 2025 20:58 — with GitHub Actions Inactive

superbeeny temporarily deployed to functional-tests January 15, 2025 21:00 — with GitHub Actions Inactive

removing sql server tests and resources

f265c79

Signed-off-by: Nick Beenham <Nicholas_Beenham@cable.comcast.com>

superbeeny temporarily deployed to publish-bicep January 16, 2025 13:44 — with GitHub Actions Inactive

superbeeny temporarily deployed to functional-tests January 16, 2025 14:00 — with GitHub Actions Inactive

kachawla approved these changes Jan 21, 2025

View reviewed changes

Merge branch 'main' into features/superbeeny/postgres-fix

dc10ea9

superbeeny temporarily deployed to publish-bicep January 21, 2025 18:59 — with GitHub Actions Inactive

superbeeny temporarily deployed to functional-tests January 21, 2025 19:06 — with GitHub Actions Inactive

Merge branch 'main' into features/superbeeny/postgres-fix

c2a7d4b

kachawla temporarily deployed to publish-bicep January 22, 2025 04:54 — with GitHub Actions Inactive

kachawla temporarily deployed to functional-tests January 22, 2025 14:14 — with GitHub Actions Inactive

brooke-hamilton merged commit f81b546 into radius-project:main Jan 22, 2025

superbeeny mentioned this pull request Jan 29, 2025

REQUEST: Approver for superbeeny radius-project/community#76

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixing issue with deployment to AKS#8249

fixing issue with deployment to AKS#8249
brooke-hamilton merged 4 commits into
radius-project:mainfrom
superbeeny:features/superbeeny/postgres-fix

superbeeny commented Jan 15, 2025

Uh oh!

radius-functional-tests Bot commented Jan 15, 2025 •

edited

Loading

Uh oh!

codecov Bot commented Jan 15, 2025 •

edited

Loading

Uh oh!

radius-functional-tests Bot commented Jan 16, 2025 •

edited

Loading

Uh oh!

kachawla left a comment

Uh oh!

kachawla Jan 21, 2025

Uh oh!

superbeeny Jan 21, 2025

Uh oh!

radius-functional-tests Bot commented Jan 21, 2025 •

edited

Loading

Uh oh!

radius-functional-tests Bot commented Jan 22, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

superbeeny commented Jan 15, 2025

Description

Type of change

Contributor checklist

Uh oh!

radius-functional-tests Bot commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

codecov Bot commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

radius-functional-tests Bot commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

kachawla left a comment

Choose a reason for hiding this comment

Uh oh!

kachawla Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

superbeeny Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

radius-functional-tests Bot commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

radius-functional-tests Bot commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

radius-functional-tests Bot commented Jan 15, 2025 •

edited

Loading

codecov Bot commented Jan 15, 2025 •

edited

Loading

radius-functional-tests Bot commented Jan 16, 2025 •

edited

Loading

radius-functional-tests Bot commented Jan 21, 2025 •

edited

Loading

radius-functional-tests Bot commented Jan 22, 2025 •

edited

Loading