Run functional tests every 2 hours and add another workflow that runs…#1020
Merged
Conversation
ytimocin
force-pushed
the
ytimocin/updateFuncTests
branch
9 times, most recently
from
238a9b7 to
f9bd925
Compare
ytimocin
commented
Mar 22, 2024
Comment on lines
+167
to
+233
| - name: Build images | ||
| if: steps.gen-id.outputs.RUN_TEST == 'true' && matrix.images != '' | ||
| run: | | ||
| # split images and directories into arrays | ||
| IFS=',' read -ra images <<< "${{ matrix.images }}" | ||
| IFS=',' read -ra directories <<< "${{ matrix.directories }}" | ||
| echo "Building images: $images" | ||
| echo "Directories: $directories" | ||
| for index in "${!images[@]}"; do | ||
| image=${images[$index]} | ||
| directory=${directories[$index]} | ||
| echo "Building image $image from directory $directory" | ||
| docker build -t ghcr.io/radius-project/$image:${{ github.run_id }} $directory | ||
| docker tag ghcr.io/radius-project/$image:${{ github.run_id }} ghcr.io/radius-project/$image:${{ github.run_id }} | ||
| # We need to think about how we can delete these images at the end of the run | ||
| docker push ghcr.io/radius-project/$image:${{ github.run_id }} | ||
| done |
Contributor
Author
There was a problem hiding this comment.
This is where we build the necessary images and push them to GHCR. Would love to get ideas on this approach. I see that for some tests we are using the latest tag but for some we are building images. What would the best approach be here?
| if: steps.gen-id.outputs.RUN_TEST == 'true' && steps.gen-id.outputs.ENABLE_DAPR == 'true' | ||
| run: | | ||
| helm repo add dapr https://dapr.github.io/helm-charts/ | ||
| helm upgrade --install dapr dapr/dapr --version=1.6 --namespace dapr-system --create-namespace --wait |
Contributor
Author
There was a problem hiding this comment.
Updated this so that if Dapr is installed there is no error.
ytimocin
force-pushed
the
ytimocin/updateFuncTests
branch
4 times, most recently
from
36bf504 to
45d9032
Compare
youngbupark
reviewed
Mar 22, 2024
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| AZURE_LOCATION: westus3 | ||
| AKS_RESOURCE_GROUP: samples-functional-tests | ||
| AKS_CLUSTER_NAME: samples-aks |
Contributor
There was a problem hiding this comment.
@ytimocin If you use the existing aks cluster, workflow must clean up the existing resource first before starting the test. I recommend to add the code to delete namespace first before starting the test.
youngbupark
reviewed
Mar 22, 2024
| aws eks update-kubeconfig --region ${{ env.AWS_REGION }} --name ${{ steps.gen-id.outputs.TEST_EKS_CLUSTER_NAME }} | ||
| timeout-minutes: 60 | ||
| continue-on-error: false | ||
| - name: Install Dapr |
Contributor
There was a problem hiding this comment.
If you use /test/azure/ bicep template, dapr is installed and maintained by AKS. So I would disable this one for AKS cluster.
ytimocin
force-pushed
the
ytimocin/updateFuncTests
branch
13 times, most recently
from
9a4526b to
a8f758f
Compare
ytimocin
force-pushed
the
ytimocin/updateFuncTests
branch
24 times, most recently
from
e9cd591 to
f70e55c
Compare
ytimocin
force-pushed
the
ytimocin/updateFuncTests
branch
from
f70e55c to
d77c6ba
Compare
… the tests on AKS instead of k3d Signed-off-by: ytimocin <ytimocin@microsoft.com>
youngbupark
approved these changes
Apr 3, 2024
Signed-off-by: ytimocin <ytimocin@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… the tests on AKS instead of k3d
Goal:
We will be collecting data for a week to see if the flakiness can be caused by k3d cluster.