Resolve login shell PATH for .app bundle launches#129
Merged
dhilgaertner merged 5 commits intomainfrom Apr 8, 2026
Merged
Conversation
When Crow.app is launched from Finder/Dock, macOS provides a minimal PATH that excludes Homebrew-installed tools like gh and glab. Add a ShellEnvironment singleton in CrowCore that resolves the user's full PATH from their login shell on first access, then inject it into all Process calls across GitManager, ProviderManager, IssueTracker, SessionService, and AppDelegate. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The bundle script only copied CrowApp into Contents/MacOS/, leaving the crow CLI binary behind. The app needs the CLI for hook event delivery but could not find it when launched from Finder. The existing findCrowBinary() already checks the same directory as the running executable, so placing crow alongside CrowApp makes it work. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShellEnvironmentsingleton in CrowCore that resolves the user's full PATH from their login shell (zsh -lc 'echo $PATH') on first access, with a 5-second timeout and fallback to well-known Homebrew pathsProcesscalls acrossGitManager,ProviderManager,IssueTracker,SessionService, andAppDelegate/usr/bin/which-based dependency check inAppDelegatewithShellEnvironment.shared.hasCommand()Closes #123
Test plan
make buildpassesswift test --package-path Packages/CrowCorepasses (101 tests)make release→ launch Crow.app from Finder (not terminal) → verify issues panel loadsgh,glab,gitcommands work in the release build🤖 Generated with Claude Code