Replace CorveilBrandmark PNG with SVG for crisper rendering#185
Merged
dhilgaertner merged 3 commits intomainfrom Apr 22, 2026
Merged
Replace CorveilBrandmark PNG with SVG for crisper rendering#185dhilgaertner merged 3 commits intomainfrom
dhilgaertner merged 3 commits intomainfrom
Conversation
The brandmark shipped as a 1.6 MB raster and looked soft at the sizes it actually renders (About window at 140 pt, sidebar at 120 pt, Manager tab header). Swap in an 8.5 KB SVG; macOS 14 NSImage loads it natively, so the only other change is the bundle-lookup extension in the two loader sites. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dgershman
approved these changes
Apr 22, 2026
Collaborator
dgershman
left a comment
dgershman
left a comment
There was a problem hiding this comment.
Code & Security Review
Critical Issues
None.
Security Review
Strengths:
- SVG is clean — no embedded
<script>,javascript:URIs, event handlers,<foreignObject>, or other XSS vectors - Image is loaded via
NSImage(contentsOf:)from a bundled resource, not from user-supplied or remote content
Concerns:
- None
Code Quality
- The change is minimal and mechanical: three
"png"→"svg"swaps plus the asset swap. Low risk. AboutView.loadBrandmark()(Sources/Crow/App/AboutView.swift:62) is a copy-paste ofBrandmarkImage.load()(Packages/CrowUI/Sources/CrowUI/CorveilTheme.swift:83). Pre-existing duplication, not introduced here, but worth consolidating in a follow-up.- SVG is 8.5 KB vs the deleted 1.6 MB PNG — nice size reduction.
- No missing newline at end of SVG file (minor, cosmetic).
Summary Table
| Priority | Issue |
|---|---|
| 🟢 Green | Pre-existing: AboutView.loadBrandmark() duplicates BrandmarkImage.load() — consider reusing |
| 🟢 Green | SVG file missing trailing newline |
Recommendation: Approve — clean, low-risk asset swap with significant file size savings. No security or correctness concerns.
Local builds write into vendor/ghostty, making `git status` flag it as "modified content" on every working copy. Set ignore = dirty on the submodule stanza so only actual pinned-commit changes surface. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CorveilBrandmark.pngfor an 8.5 KB SVG so the brandmark stays sharp at every rendered size (About window 140 pt, sidebar 120 pt, Manager tab header).BrandmarkImageloader shape — macOS 14NSImage(contentsOf:)handles SVG natively, so only thewithExtension:arg and the.copy(...)resource path change.Package.swift,Sources/Crow/App/AboutView.swift,Packages/CrowUI/Sources/CrowUI/CorveilTheme.swift, plus the asset swap underSources/Crow/Resources/.Closes #183
Test plan
make buildsucceedsSessionDetailView) renders the brandmark cleanlySessionListView) shows the brandmark at 120 pt with 0.7 opacity, no raster fuzzCorveilTheme.bgDeep/bgSurface🤖 Generated with Claude Code