Skip to content

Conversation

@elipe17
Copy link

@elipe17 elipe17 commented Jan 5, 2026

Summary of Changes

  • Alex and Mo resolved an issue where an STT was receiving consistent 502 errors. The issue was caused by the frontend container not having enough disk space.
  • Added lots of extra disk space for frontend containers

How to Test

  1. Deploy and verify the app has 2GB of disk

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

  • [insert ACs here]
  • lfrohlich and/or adpennington confirmed that ACs are met.

Deliverable 2: Tested Code

  • Are all areas of code introduced in this PR meaningfully tested?
    • If this PR introduces backend code changes, are they meaningfully tested?
    • If this PR introduces frontend code changes, are they meaningfully tested?
  • Are code coverage minimums met?
    • Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
    • Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

  • Are backend code style checks passing on CircleCI?
  • Are frontend code style checks passing on CircleCI?
  • Are code maintainability principles being followed?

Deliverable 4: Accessible

  • Does this PR complete the epic?
  • Are links included to any other gov-approved PRs associated with epic?
  • Does PR include documentation for Raft's a11y review?
  • Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

  • Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

  • Does this PR provide background for why coding decisions were made?
  • If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces dependencies, are their licenses documented?
  • Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

  • Does the OWASP Scan pass on CircleCI?
  • Do manual code review and manual testing detect any new security issues?
  • If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

  • the purpose of the research
  • methods used to conduct the research
  • who participated in the research
  • what was tested and how
  • impact of research on TDP
  • (if applicable) final design mockups produced for TDP development

@elipe17 elipe17 self-assigned this Jan 5, 2026
@elipe17 elipe17 added bug frontend dev raft review This issue is ready for raft review labels Jan 5, 2026
@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.95%. Comparing base (431eb96) to head (d8283e5).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5575      +/-   ##
===========================================
- Coverage    91.95%   91.95%   -0.01%     
===========================================
  Files          471      471              
  Lines        20105    20117      +12     
  Branches       437      439       +2     
===========================================
+ Hits         18488    18499      +11     
  Misses        1537     1537              
- Partials        80       81       +1     
Flag Coverage Δ
dev-backend 92.15% <ø> (+<0.01%) ⬆️
dev-frontend 90.34% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49abc68...d8283e5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@jtimpe jtimpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous setting of 256M is pretty low, but i am still curious what specifically pushed us over the limit, if that was a dependency add/upgrade or just us adding new features/assets.

memory: 256M
instances: 1
disk_quota: 256M
disk_quota: 2G

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you decide to go with 2G? I increased it to 512G in prod, but I think we are very safe with 1G

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disk space is "free" in cloud.gov (up to 7GB). I figured better to be safe than sorry.

@elipe17
Copy link
Author

elipe17 commented Jan 6, 2026

The previous setting of 256M is pretty low, but i am still curious what specifically pushed us over the limit, if that was a dependency add/upgrade or just us adding new features/assets.

@jtimpe I did some digging and this seems to be the most likely candidate for causing the out of disk space error. We don't have this specified so it is allowed to go up to 1GB.

@elipe17 elipe17 merged commit 620828c into develop Jan 6, 2026
12 checks passed
@elipe17 elipe17 deleted the bug-frontend-502-disk-space branch January 6, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug dev frontend raft review This issue is ready for raft review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants