Skip to content

Calls to settle must handle missing or old balance proofs  #2214

@hackaugusto

Description

@hackaugusto

Problem Definition

The state machine assumes the partner will always successfully call update transfer, and includes both balance proofs in the settlement call, if the update transaction fails then the settle transaction will also fail. To fix this the settle state change should not include the balance proof, but the balance hash, and the balance proof should be recovered from the WAL.

Additionally the state machine assumes always the latest balance proof is used, if an old balance proof is used the state changes in database needs to be searched to find the correct balance proof data

related to: #2129

Split it into two issues:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions