Make sure that proxies have checks for all `assert()` and `require()` in the Solidity sources

[pirapira]

This issue keeps track of making sure that the proxies contain checks for all assert()s and require()s in the Solidity sources.

• the target version of the Raiden client is raiden:develop.
• the target version of the Raiden contract is the version that raiden:develop uses

steps

• list all assert()s and require()s in the Solidity sources
• for each one, make sure that
  • the assert() or require() has corresponding checks in all related proxies, or
  • the assert() or require() can never be reached from any of the proxies

[pirapira]

@karlb does the service codebase have something similar to contract proxies in the client?

[karlb]

No, there are less contract interactions and things have been comparatively simple, so that pulling out the contract calls and detecting every possible error case was not necessary, so far.

[pirapira]

That's good to know. Thanks.

[rakanalh]

Augusto is currently looking at the proxies & contracts to make sure they we in sync.

[pirapira]

The contracts to cover:

• TokenNetworkRegistry Make sure that proxies have checks for all assert() and require() in TokenNetworkRegistry #4792
• TokenNetwork
• SecretRegistry
• HumanStandardToken

[pirapira]

Suspended till I understand the norm #4828

[pirapira]

Also stuck on #4829