Skip to content

Use DEFAULT_MEDIATION_FEE_MARGIN in test#4786

Merged
karlb merged 1 commit into
raiden-network:developfrom
karlb:use-fee-margin-in-test
Sep 9, 2019
Merged

Use DEFAULT_MEDIATION_FEE_MARGIN in test#4786
karlb merged 1 commit into
raiden-network:developfrom
karlb:use-fee-margin-in-test

Conversation

@karlb
Copy link
Copy Markdown
Contributor

@karlb karlb commented Sep 9, 2019

Description

in test_mediated_transfer_with_fees. In its current form, the test
works without this change. But changing the fee amount in the test or
the DEFAULT_MEDIATION_FEE_MARGIN will break the test without clearly
showing the cause. So it's better to handle this case explicitly.

PR review check list

Quality check list that cannot be automatically verified.

  • Safety
  • Code quality
    • Error conditions are handled
    • Exceptions are propagated to the correct parent greenlet
    • Exceptions are correctly classified as recoverable or unrecoverable
  • Compatibility
    • State changes are forward compatible
    • Transport messages are backwards and forward compatible
  • Commits
    • Have good messages
    • Squashed unecessary commits
  • If it's a bug fix:
    • Regression test for the bug
      • Properly covers the bug
      • If an integration test is used, it could not be written as a unit test
  • Documentation
    • A new CLI flag was introduced, is there documentation that explains usage?
  • Specs
    • If this is a protocol change, are the specs updated accordingly? If so, please link PR from the specs repo.
  • Is it a user facing feature/bug fix?
    • Changelog entry has been added

in `test_mediated_transfer_with_fees`. In its current form, the test
works without this change. But changing the fee amount in the test or
the DEFAULT_MEDIATION_FEE_MARGIN will break the test without clearly
showing the cause. So it's better to handle this case explicitly.
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 9, 2019

Codecov Report

Merging #4786 into develop will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4786      +/-   ##
===========================================
- Coverage    80.92%   80.79%   -0.14%     
===========================================
  Files          119      118       -1     
  Lines        14343    14332      -11     
  Branches      2209     2207       -2     
===========================================
- Hits         11607    11579      -28     
- Misses        2087     2098      +11     
- Partials       649      655       +6
Impacted Files Coverage Δ
raiden/storage/restore.py 88.88% <0%> (-4.77%) ⬇️
raiden/storage/serialization/types.py 64.17% <0%> (-4.48%) ⬇️
raiden/waiting.py 81.54% <0%> (-4.17%) ⬇️
raiden/network/transport/matrix/client.py 68.5% <0%> (-1.3%) ⬇️
raiden/ui/app.py 24.6% <0%> (-0.8%) ⬇️
raiden/api/python.py 68.25% <0%> (-0.53%) ⬇️
raiden/network/transport/matrix/transport.py 80.74% <0%> (-0.3%) ⬇️
raiden/network/proxies/token_network.py 51.45% <0%> (-0.13%) ⬇️
raiden/utils/mediation_fees.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 991e27b...afe0b03. Read the comment docs.

Copy link
Copy Markdown
Contributor

@palango palango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@karlb karlb merged commit 72c0b8f into raiden-network:develop Sep 9, 2019
@karlb karlb deleted the use-fee-margin-in-test branch September 9, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants