Use DEFAULT_MEDIATION_FEE_MARGIN in test#4786
Merged
Merged
Conversation
in `test_mediated_transfer_with_fees`. In its current form, the test works without this change. But changing the fee amount in the test or the DEFAULT_MEDIATION_FEE_MARGIN will break the test without clearly showing the cause. So it's better to handle this case explicitly.
13 tasks
Codecov Report
@@ Coverage Diff @@
## develop #4786 +/- ##
===========================================
- Coverage 80.92% 80.79% -0.14%
===========================================
Files 119 118 -1
Lines 14343 14332 -11
Branches 2209 2207 -2
===========================================
- Hits 11607 11579 -28
- Misses 2087 2098 +11
- Partials 649 655 +6
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
in
test_mediated_transfer_with_fees. In its current form, the testworks without this change. But changing the fee amount in the test or
the DEFAULT_MEDIATION_FEE_MARGIN will break the test without clearly
showing the cause. So it's better to handle this case explicitly.
PR review check list
Quality check list that cannot be automatically verified.