Avoid adding a token at NULL_ADDRESS#4876
Merged
rakanalh merged 5 commits intoSep 23, 2019
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## develop #4876 +/- ##
===========================================
- Coverage 80.97% 80.81% -0.17%
===========================================
Files 120 120
Lines 14510 14515 +5
Branches 2236 2238 +2
===========================================
- Hits 11750 11730 -20
- Misses 2112 2129 +17
- Partials 648 656 +8
Continue to review full report at Codecov.
|
fecad1d to
3d27989
Compare
rakanalh
previously requested changes
Sep 16, 2019
added 3 commits
September 19, 2019 15:43
because then the call to TokenNetworkRegistry will fail. This fixes raiden-network#4875.
4b67094 to
bd6dc0b
Compare
bd6dc0b to
2cdbb66
Compare
Contributor
LefterisJP
suggested changes
Sep 19, 2019
LefterisJP
approved these changes
Sep 19, 2019
13 tasks
655fdea to
0de4d4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because then the call to TokenNetworkRegistry will fail.
This fixes #4875.
Fixes: 4815Description
Please, describe what this PR does in detail:
After this PR, TokenNetworkRegistry proxy refuses to register a token contract at address 0x00000000....00. The constructor of TokenNetwork contract checks against this case, so the contract proxy needs to check this condition.
I didn't add post-failure checks because the precondition checks will completely remove the possibility that the token address is 0x00000000..00.
PR review check list
Quality check list that cannot be automatically verified.