-
Notifications
You must be signed in to change notification settings - Fork 372
Token network registry preconditions #4936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hackaugusto
merged 11 commits into
raiden-network:develop
from
rakanalh:token-network-registry-preconditions
Sep 23, 2019
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9edcc07
Add precondition checks for the token network registry
rakanalh a02ea7e
Refactor the token network registry
rakanalh 325970c
Remove string matching from exception in tests (error prone)
rakanalh 560d6ba
Fix gas limit keys
rakanalh 49b9c55
Check that chain id matches the one Raiden is running on
rakanalh b5a0313
use gas_measurements.get to protect against typos
rakanalh 2b019ca
Introduce exceptions for invalid deposit limits
rakanalh 434779c
Remove redundant settlement timeout methods, use existing
rakanalh ace16c8
Validate deposit limits and max token networks vs created
rakanalh 2861539
Fix token network registry tests
rakanalh 1efc4b6
Wait for the block at which token was deployed to be confirmed
rakanalh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -161,6 +161,18 @@ class InvalidTokenAddress(RaidenError): | |
| """ Raised if the token address is invalid """ | ||
|
|
||
|
|
||
| class InvalidTokenNetworkDepositLimit(RaidenError): | ||
| """ Raised when an invalid token network deposit | ||
| limit is passed to the token network registry proxy. | ||
| """ | ||
|
|
||
|
|
||
| class InvalidChannelParticipantDepositLimit(RaidenError): | ||
| """ Raised when an invalid channel participant | ||
| deposit limit is passed to the token network registry proxy. | ||
| """ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This can only happen when the API didn't check the condition. This situation should crash the node with |
||
|
|
||
|
|
||
| class STUNUnavailableException(RaidenError): | ||
| pass | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can happen only when the API didn't check enough conditions. This should crash the node with
BrokenPreconditionError.