Handle RecoverableError in the python api's set_total_deposit#4938
Merged
Conversation
d1bdd14 to
f08f014
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4938 +/- ##
==========================================
Coverage ? 80.77%
==========================================
Files ? 120
Lines ? 14519
Branches ? 2238
==========================================
Hits ? 11728
Misses ? 2135
Partials ? 656
Continue to review full report at Codecov.
|
Contributor
Author
|
Oh man come on. Changed 2 lines to catch an exception. Wrote an entire new test which recreates a race (took a bit of time as we did not have any such tests in the rest api) to trigger the bug seen in the issue ... and still the coverage is decreased?!?! |
rakanalh
reviewed
Sep 23, 2019
f08f014 to
87504b5
Compare
rakanalh
approved these changes
Sep 23, 2019
Contributor
rakanalh
left a comment
There was a problem hiding this comment.
LGTM, thanks for taking this one.
87504b5 to
2103b6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4937
Description
Please, describe what this PR does in detail:
PR review check list
Quality check list that cannot be automatically verified.