Remove checks that are not in the onchain contract#4956
Merged
LefterisJP merged 1 commit intoSep 23, 2019
Conversation
13 tasks
Codecov Report
@@ Coverage Diff @@
## develop #4956 +/- ##
===========================================
- Coverage 80.47% 80.45% -0.02%
===========================================
Files 120 120
Lines 14603 14599 -4
Branches 2265 2263 -2
===========================================
- Hits 11752 11746 -6
Misses 2185 2185
- Partials 666 668 +2
Continue to review full report at Codecov.
|
TokenNetworkRegistry.createERC20() succeeds even when the stored chain_id value is different from the current chain_id of the blockchain. Since the proxies should not check what's not checked onchain, I'm removing the checks that do not exist in the onchain contracts.
43de8e2 to
72f61b5
Compare
LefterisJP
approved these changes
Sep 23, 2019
Contributor
LefterisJP
left a comment
There was a problem hiding this comment.
LGTM, I agree with this change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TokenNetworkRegistry.createERC20() succeeds even when the stored
chain_id value is different from the current chain_id of the blockchain.
Since the proxies should not check what's not checked onchain,
I'm removing the checks that do not exist in the onchain contracts.
This PR comes from this conversation #4936 (comment)
Description
Please, describe what this PR does in detail:
It's a bug fix. Before this PR, the proxy failed even when the transaction would succeed.
PR review check list
Quality check list that cannot be automatically verified.