Skip to content

Raise BrokenPreconditionError on invalid inputs #4957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pirapira wants to merge 1 commit into from
Closed

Raise BrokenPreconditionError on invalid inputs #4957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions raiden/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,18 +161,6 @@ class InvalidTokenAddress(RaidenError):
""" Raised if the token address is invalid """


class InvalidTokenNetworkDepositLimit(RaidenError):
""" Raised when an invalid token network deposit
limit is passed to the token network registry proxy.
"""


class InvalidChannelParticipantDepositLimit(RaidenError):
""" Raised when an invalid channel participant
deposit limit is passed to the token network registry proxy.
"""


class STUNUnavailableException(RaidenError):
pass

Expand Down
9 changes: 3 additions & 6 deletions raiden/network/proxies/token_network_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,7 @@
from raiden.constants import NULL_ADDRESS, NULL_ADDRESS_BYTES
from raiden.exceptions import (
BrokenPreconditionError,
InvalidChannelParticipantDepositLimit,
InvalidToken,
InvalidTokenAddress,
InvalidTokenNetworkDepositLimit,
RaidenRecoverableError,
RaidenUnrecoverableError,
)
Expand Down Expand Up @@ -113,15 +110,15 @@ def add_token(
)

if token_address == NULL_ADDRESS_BYTES:
raise InvalidTokenAddress("The call to register a token at 0x00..00 will fail.")
raise BrokenPreconditionError("The call to register a token at 0x00..00 will fail.")

if token_network_deposit_limit <= 0:
raise InvalidTokenNetworkDepositLimit(
raise BrokenPreconditionError(
f"Token network deposit limit of {token_network_deposit_limit} is invalid"
)

if channel_participant_deposit_limit > token_network_deposit_limit:
raise InvalidChannelParticipantDepositLimit(
raise BrokenPreconditionError(
f"Channel participant deposit limit of "
f"{channel_participant_deposit_limit} is invalid"
)
Expand Down