Skip to content

fix deprecation warning ruby 2.7+ #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
byroot merged 1 commit into from
May 7, 2021
+3 −3
Merged

fix deprecation warning ruby 2.7+ #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/execjs/external_runtime.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def exec_runtime(filename)
begin
command = binary.split(" ") << filename
`#{shell_escape(*command)} 2>&1 > #{path}`
output = File.open(path, 'rb', @popen_options) { |f| f.read }
output = File.open(path, 'rb', **@popen_options) { |f| f.read }
ensure
File.unlink(path) if path
end
Expand All @@ -197,7 +197,7 @@ def shell_escape(*args)

def exec_runtime(filename)
command = "#{Shellwords.join(binary.split(' ') << filename)} 2>&1"
io = IO.popen(command, @popen_options)
io = IO.popen(command, **@popen_options)
output = io.read
io.close

Expand All @@ -209,7 +209,7 @@ def exec_runtime(filename)
end
else
def exec_runtime(filename)
io = IO.popen(binary.split(' ') << filename, @popen_options.merge({err: [:child, :out]}))
io = IO.popen(binary.split(' ') << filename, **(@popen_options.merge({err: [:child, :out]})))
output = io.read
io.close

Expand Down