Remove unused faraday gems from Gemfile#160
Merged
mateusdeap merged 7 commits intorailsbump:mainfrom Apr 9, 2026
Merged
Conversation
CGI.parse was removed in Ruby 4.0, causing VCR 6.3.1 to fail.
Unmaintained since 2022 and incompatible with Ruby 4.0 (C extension). Ruby 4.0 ships with the debug gem as a built-in replacement.
Its dependency rouge uses CGI.parse which is removed in Ruby 4.0. Rails built-in error pages are sufficient for development.
faraday, faraday_middleware, faraday-multipart, and faraday-retry were listed explicitly but never used directly in app code. Octokit pulls in faraday transitively via sawyer. Removing the explicit pins allows faraday to resolve to 2.x (from 1.x), dropping the deprecated faraday_middleware and several unused adapter gems.
JuanVqz
requested review from
a team,
jeremysmithco and
mateusdeap
and removed request for
jeremysmithco and
mateusdeap
jeremysmithco
approved these changes
Apr 9, 2026
Contributor
jeremysmithco
left a comment
jeremysmithco
left a comment
There was a problem hiding this comment.
This looks good, too!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
faraday,faraday_middleware,faraday-multipart, andfaraday-retryfrom the Gemfileoctokit(viasawyer)faraday_middlewareand several unused adapter gemsDepends on #159