Open
Conversation
bennothommo
suggested changes
Mar 29, 2020
Contributor
bennothommo
left a comment
bennothommo
left a comment
There was a problem hiding this comment.
@marzochi Some code cleanup required before we can review and potentially merge this.
Co-Authored-By: Ben Thomson <ben@abweb.com.au>
Co-Authored-By: Ben Thomson <ben@abweb.com.au>
Co-Authored-By: Ben Thomson <ben@abweb.com.au>
Co-Authored-By: Ben Thomson <ben@abweb.com.au>
Co-Authored-By: Ben Thomson <ben@abweb.com.au>
Co-Authored-By: Ben Thomson <ben@abweb.com.au>
Co-Authored-By: Ben Thomson <ben@abweb.com.au>
Co-Authored-By: Ben Thomson <ben@abweb.com.au>
Co-Authored-By: Ben Thomson <ben@abweb.com.au>
Co-Authored-By: Ben Thomson <ben@abweb.com.au>
Co-Authored-By: Ben Thomson <ben@abweb.com.au>
Co-Authored-By: Ben Thomson <ben@abweb.com.au>
Co-Authored-By: Ben Thomson <ben@abweb.com.au>
Co-Authored-By: Ben Thomson <ben@abweb.com.au>
Contributor
|
@marzochi Thanks for making those changes - just make sure to do the following as well: |
Author
|
Thanks again, I removed unnecessary codes. I hope it'll be passed :) |
Member
|
Very cool @mhanoglu. Added a note to review this and implement into the core widget Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.