Why code field is readOnly (MigrationModel)?

[Air-Petr]

I wonder why does code field in migration popup have readOnly: true property? Are there any reasons? It would be nice to edit code before creating migration file.

builder-plugin/classes/migrationmodel/fields.yaml

Line 11 in 008f3e8

readOnly: true

[bennothommo]

@Air-Petr Since the migration is run immediately once the migration popup is closed, it may be risky to allow edits here in case the migration cannot complete.

If you want to make manual changes to the migration, it's best to do this in the Versions section of the Builder plugin, where potential errors are more thoroughly checked and you have the capability of committing and rolling back migrations.

[Air-Petr]

Yes, I know about Versions section. But it feels unusual a bit when migrations are applied instantly. Also, quite often I have to do a rollback right after migration file was created. So is there a way to eliminate this unnecessary step?

I see two scenarios:

1. Create a checkbox Also apply in the Migration popup and change name of the blue button to Save. So the migrations will be applied only if checkbox is checked.
2. Create a second button called Save (that saves files, but don't apply them).

First one seems to be more concise. I could make some changes in code and make pull request after that.

[bennothommo]

@Air-Petr I'd be happy to accept a PR that allows you to edit the migration in the popup, only if it can: a) handle if the migration is incorrect or cannot be run by showing an error and rolling back any changes made and, b) reflect the migration's changes immediately in the database table schema editor when the popup closes.

[bennothommo]

This feature is now available as of 1f94ebe.