"Add ID column" Button for Migration Editor#293
Merged
bennothommo merged 16 commits intorainlab:masterfrom Jul 26, 2019
danharrin:patch-1
Merged
"Add ID column" Button for Migration Editor#293bennothommo merged 16 commits intorainlab:masterfrom danharrin:patch-1
bennothommo merged 16 commits intorainlab:masterfrom
danharrin:patch-1
Conversation
bennothommo
suggested changes
Jul 21, 2019
Co-Authored-By: Ben Thomson <ben@abweb.com.au>
Co-Authored-By: Ben Thomson <ben@abweb.com.au>
Contributor
Author
|
All done @bennothommo |
Contributor
|
@danharrin I have tested this - it works fine with no columns inserted, but if you were to enter a column (say a string) first, then click the "Add ID" button, it overwrites the first column. See below:
|
bennothommo
approved these changes
Jul 23, 2019
Contributor
Author
|
@bennothommo @w20k that issue should be fixed with my most recent commit. |
w20k
reviewed
Jul 24, 2019
Contributor
Author
|
I apologise @w20k, that was used during testing and was not recompiled. It's been fixed. |
|
@bennothommo - done, but re-testing needed! |
bennothommo
reviewed
Jul 25, 2019
Contributor
|
@danharrin tested it and it is working all good now. Just a couple of minor tweaks and I'll merge it! Well done :) |
Contributor
Author
|
Done the explicit checks @bennothommo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I always see myself repeating the same few steps on all of my models to add an ID column, so I added a button to do it for me - just to save that little bit of time.