Skip to content

Comments

Redo of #304#309

Merged
LukeTowers merged 8 commits intomasterfrom
wip/filipac-changes
Nov 5, 2019
Merged

Redo of #304#309
LukeTowers merged 8 commits intomasterfrom
wip/filipac-changes

Conversation

@LukeTowers
Copy link
Contributor

This is a resubmission of #304. @bennothommo please review and let me know what's left before it can be merged.

filipac and others added 8 commits October 17, 2019 15:30
@bennothommo
Copy link
Contributor

@LukeTowers it just needs to be tested, that's all. I believe @filipac sorted out the last issue that @w20k spotted.

@LukeTowers
Copy link
Contributor Author

@w20k when you get a moment could you test this out?

@w20k
Copy link

w20k commented Nov 5, 2019

@LukeTowers sure! Might wait a little bit when octoblabs will be back alive ;)

@LukeTowers
Copy link
Contributor Author

@petehalverson eagerly awaiting octodock updates :)

@petehalverson
Copy link

Ok. octodock is back and ready to go!

@LukeTowers
Copy link
Contributor Author

Thanks @petehalverson, appreciate it!

@w20k
Copy link

w20k commented Nov 5, 2019

@LukeTowers seems like it's working properly now.
@petehalverson thanks a lot! ;)

Screenshots:
Screenshot 2019-11-05 at 21 38 05
Screenshot 2019-11-05 at 21 38 11

@LukeTowers
Copy link
Contributor Author

Thanks @w20k. Good work on the feature @filipac!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants