Added requirement for user to enter his old password when changing important settings.#303
Merged
bennothommo merged 7 commits intorainlab:masterfrom Jul 25, 2019
mahaupt:master
Merged
Added requirement for user to enter his old password when changing important settings.#303bennothommo merged 7 commits intorainlab:masterfrom mahaupt:master
bennothommo merged 7 commits intorainlab:masterfrom
mahaupt:master
Conversation
…s password, email or name. Also included the AuthException class into Account.php to prevent an error on line 201.
LukeTowers
previously requested changes
Dec 10, 2017
Contributor
LukeTowers
left a comment
LukeTowers
left a comment
There was a problem hiding this comment.
Please add an option in the component properties (disabled by default) to enable this functionality so that we can maintain backwards compatibility with existing implementations
Contributor
Author
|
I added an option to the settings page but did not make use of the language files, yet. |
Contributor
|
@cbacon93 If you are interested in seeing this merged in (I know it has been a while), would you mind resolving the conflicts on your PR branch? :) |
bennothommo
suggested changes
Jul 4, 2019
bennothommo
approved these changes
Jul 25, 2019
Contributor
|
@cbacon93 I have finished off the functionality as per the review notes for you, as I was keen to see this feature implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added requirement for user to enter his old password when changing his password, email or name.
I also included the AuthException class into Account.php to prevent an error on line 201.
#301