You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello,
I'd like to try to look at this from a different perspective.
I think having pretranslated basic strings for the components is a good idea.
In my case I have multiple installations in multiple languages that are updated by automatic scripts.
For educational purposes you can maybe put a comment next to the original language content.
Moving the translations into the theme is a possible solution but in my opinion it is more efficient to have them in the plugin in case of multiple installations.
This way you can comfortably update multiple installations automatically without having to take into account different translations between themes on a case by case basis.
Of course for those who manage a single project this makes no sense. :)
Thank you for your work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves every string from template files into lang files enabling front localization.
It doesn't include mail template localization (cf #402 (comment)_ )
Closes #402