Add remember option to registration#436
Closed
bernardotavares wants to merge 2 commits intorainlab:masterfrom
Closed
Add remember option to registration#436bernardotavares wants to merge 2 commits intorainlab:masterfrom
bernardotavares wants to merge 2 commits intorainlab:masterfrom
Conversation
Contributor
|
@bernardotavares What do you propose will happen if the "Remember login mode" setting is set to "Ask", as there is currently no field in the registration form to ask them if they wish to set up a "remembered" session. Should we assume that it's not a remembered session for registration? |
Author
|
Yes I agree with that. Asking about the session in the registration form its a bit uncommon right? And a non-persistent session by default seems like the best practice security-wise. |
bennothommo
suggested changes
May 28, 2020
Member
|
Fixed v1.5.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #312
On registration, in case the automatic Activation is ON or the settings do not require activation, shouldn't we add the remember option in the registration as well? So we don't get the persistent session by default in the first login?