Skip to content

Add module exports #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hardingjam wants to merge 2 commits into from
Closed

Add module exports #135

hardingjam wants to merge 2 commits into from

Conversation

@hardingjam
Copy link

@hardingjam hardingjam commented Nov 28, 2024

Motivation

Difficulties testing FE components with Vitest when importing this package

Solution

Export esm modules as required.

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@hardingjam hardingjam requested a review from dcatki November 28, 2024 08:30
@hardingjam hardingjam self-assigned this Nov 28, 2024
@hardingjam hardingjam requested review from hardyjosh and removed request for dcatki November 28, 2024 08:34
@hardyjosh
Copy link
Contributor

hardyjosh commented Dec 6, 2024

not necessary

@hardyjosh hardyjosh closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hardyjosh hardyjosh Awaiting requested review from hardyjosh

Assignees

@hardingjam hardingjam

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hardingjam @hardyjosh