Skip to content

fix copyright #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thedavidmeister merged 1 commit into from
Sep 8, 2025
Merged

fix copyright #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/error/ErrDecimalFloat.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: LicenseRef-DCL-1.0
// SPDX-FileCopyrightText: Copyright (c) 2020 thedavidmeister
// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

LGTM on attribution.

Same optional note about year range if applicable.

-// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
+// SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
// SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd
🤖 Prompt for AI Agents 
In src/error/ErrDecimalFloat.sol around line 2 the SPDX copyright attribution is
acceptable as-is, but optionally update the SPDX-FileCopyrightText to include an
explicit year or year range (e.g., "2020-2025" or "2020") if your project policy
requires a year range; change the string accordingly and commit the updated SPDX
header, otherwise leave the line unchanged since the reviewer approved it.

pragma solidity ^0.8.25;

import {Float} from "../lib/LibDecimalFloat.sol";
Expand Down
2 changes: 1 addition & 1 deletion src/error/ErrParse.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: LicenseRef-DCL-1.0
// SPDX-FileCopyrightText: Copyright (c) 2020 thedavidmeister
// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Attribution updated correctly.

Consider a year range if contributions continued beyond 2020.

-// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
+// SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
// SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd
🤖 Prompt for AI Agents 
In src/error/ErrParse.sol around line 2, the SPDX copyright header currently
lists a single year (2020); update it to a year range reflecting continued
contributions (for example "2020-2025" or "2020-present") to correctly attribute
ongoing work, and ensure the SPDX line remains a single-line comment starting
with "// SPDX-FileCopyrightText:" followed by the chosen year range and the
original owner string.

pragma solidity ^0.8.25;

/// @dev Thrown when the decimal point is malformed in a float string.
Expand Down
2 changes: 1 addition & 1 deletion src/lib/format/LibFormatDecimalFloat.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: LicenseRef-DCL-1.0
// SPDX-FileCopyrightText: Copyright (c) 2020 thedavidmeister
// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

SPDX copyright holder update looks good.

Consider updating the year to a range if contributions continued after 2020.

Apply if appropriate:

-// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
+// SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
// SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd
🤖 Prompt for AI Agents 
In src/lib/format/LibFormatDecimalFloat.sol around line 2, the SPDX copyright
header uses a single year (2020); update it to a year range to reflect continued
contributions (e.g., 2020-2025) by replacing the line with the same SPDX header
but with the appropriate end year range for Rain Open Source Software Ltd —
adjust the end year to the latest contribution year and keep the SPDX header
format unchanged.

pragma solidity ^0.8.25;

import {LibDecimalFloat, Float} from "../LibDecimalFloat.sol";
Expand Down
2 changes: 1 addition & 1 deletion src/lib/parse/LibParseDecimalFloat.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: LicenseRef-DCL-1.0
// SPDX-FileCopyrightText: Copyright (c) 2020 thedavidmeister
// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Header owner change approved.

Apply year range if the file saw commits after 2020.

-// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
+// SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
// SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd
🤖 Prompt for AI Agents 
In src/lib/parse/LibParseDecimalFloat.sol around line 2, the SPDX copyright
header was changed and needs a year range if the file has commits after 2020;
determine the file's last commit year (e.g., via git log -1 --format=%ad
--date=format:%Y) and update the SPDX header to use a year range from 2020 to
that year (e.g., 2020-2025) while keeping the owner as Rain Open Source Software
Ltd.

pragma solidity ^0.8.25;

import {LibParseChar} from "rain.string/lib/parse/LibParseChar.sol";
Expand Down
2 changes: 1 addition & 1 deletion test/src/lib/format/LibFormatDecimalFloat.countSigFigs.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: LicenseRef-DCL-1.0
// SPDX-FileCopyrightText: Copyright (c) 2020 thedavidmeister
// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Header change acknowledged.

If work spans multiple years, use a year range for accuracy.

-// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
+// SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
// SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd
🤖 Prompt for AI Agents 
In test/src/lib/format/LibFormatDecimalFloat.countSigFigs.t.sol around line 2,
the SPDX header lists a single year ("2020"); update it to a year range to
reflect multi-year work (for example "2020-2025" or "2020-<current year>") so
the copyright span is accurate; replace the single-year token with the
appropriate start–end range in the SPDX header.

pragma solidity =0.8.25;

import {Test} from "forge-std/Test.sol";
Expand Down
2 changes: 1 addition & 1 deletion test/src/lib/format/LibFormatDecimalFloat.toDecimalString.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: LicenseRef-DCL-1.0
// SPDX-FileCopyrightText: Copyright (c) 2020 thedavidmeister
// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Consistent with the PR intent.

Optional: adjust to a year range for precision.

-// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
+// SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
// SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd
🤖 Prompt for AI Agents 
In test/src/lib/format/LibFormatDecimalFloat.toDecimalString.t.sol around line
2, the SPDX copyright header currently lists a single year; update it to a year
range for greater precision (e.g., "2020-2025" or the current year) by replacing
the single year with an inclusive range in the SPDX-FileCopyrightText line.

pragma solidity =0.8.25;

import {Test} from "forge-std/Test.sol";
Expand Down