Potential fix for code scanning alert no. 22: Client-side cross-site scripting#175
Merged
Potential fix for code scanning alert no. 22: Client-side cross-site scripting#175
Conversation
…scripting Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/rajbos/github-copilot-token-usage/security/code-scanning/22
In general, to fix DOM-based XSS when using
innerHTML, ensure that any untrusted data interpolated into HTML is first passed through contextual escaping or, better, avoid building HTML as strings and instead use DOM APIs (createElement,textContent,appendChild) so the browser treats untrusted data as text, not markup.For this specific case, we should keep the existing behavior (a single call to
renderSessionTablethat returns an HTML string) but ensure that any interpolated values that may be strings are properly escaped. The file already uses anescapeHtmlhelper when rendering error messages, so the best fix is:escapeHtmlhelper available torenderSessionTable(if it is not already in scope where we need it).renderSessionTable, applyescapeHtmlto any string fields coming fromSessionFileDetails(e.g.,sf.editorSource, any file path/name, or other textual attributes) before including them in template literals that contribute to the final HTML string.Number(...)) before interpolation to avoid accidental string injection.Since we are restricted to edits in this file and must not alter behavior more than necessary, we will:
safeText(value: unknown): stringaboverenderSessionTable, which uses the existingescapeHtml(assumed defined elsewhere in the same file) if the value is a string, or stringifies non-strings safely.sf.editorSourcewhen constructing keys or labels that end up rendered into HTML to usesafeText.renderSessionTablethat use fields fromdetailedFilesgo throughsafeTextbefore being concatenated.This way,
renderSessionTablecan continue returning an HTML string, but any data derived from tainted message content is escaped before reachinginnerHTML, eliminating the XSS vector without changing the visible functionality.Suggested fixes powered by Copilot Autofix. Review carefully before merging.