Fix customization adoption rate excluding unresolved workspaces#242
Merged
Fix customization adoption rate excluding unresolved workspaces#242
Conversation
Track unresolved workspaces in customization matrix to prevent incorrect 100% adoption rate. Unresolved workspaces (failed workspace resolution or missing workspace.json/meta.json files) are now counted as repos without customizations, ensuring accurate adoption rate calculation. Co-authored-by: rajbos <6085745+rajbos@users.noreply.github.com>
Use Math.min() to prevent substring() errors when workspace IDs are shorter than 8 characters. Co-authored-by: rajbos <6085745+rajbos@users.noreply.github.com>
Show ellipsis only when workspace ID length exceeds 8 characters to avoid misleading display like 'abc123...' for short IDs. Co-authored-by: rajbos <6085745+rajbos@users.noreply.github.com>
Replace magic number 8 with WORKSPACE_ID_DISPLAY_LENGTH constant for better code clarity and maintainability. Co-authored-by: rajbos <6085745+rajbos@users.noreply.github.com>
- Move WORKSPACE_ID_DISPLAY_LENGTH to class-level constant for better discoverability - Refactor workspace ID extraction to avoid redundant calls in try/catch blocks - Improves code maintainability and performance Co-authored-by: rajbos <6085745+rajbos@users.noreply.github.com>
Move extractWorkspaceIdFromSessionPath outside try-catch to eliminate redundant extraction attempts. The extraction is safe and doesn't need exception handling, so it can be done once before attempting workspace resolution. Co-authored-by: rajbos <6085745+rajbos@users.noreply.github.com>
- Format ternary expression with proper indentation and line breaks - Add detailed comment explaining why sessionCount is 0 for unresolved workspaces - Improves code readability and maintainability Co-authored-by: rajbos <6085745+rajbos@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix incorrect customization adoption rate in fluency score
Fix customization adoption rate excluding unresolved workspaces
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fluency Score customization adoption rate incorrectly showed 100% when users worked in repositories without customizations. Workspace resolution failures (missing
workspace.json/meta.json) caused repos to be excluded from both numerator and denominator of the adoption rate calculation.Changes
Track unresolved workspaces
extractWorkspaceIdFromSessionPath()to extract workspace IDs independent of folder resolutionunresolvedWorkspaceIdsSet to track workspaces that failed resolutionInclude unresolved workspaces in matrix
workspacesWithIssuesfor each unresolved workspaceUnresolved (<id>...)with truncated workspace IDBefore:
After:
This conservative approach assumes unresolved workspaces lack customizations, providing accurate adoption metrics.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
update.code.visualstudio.com/opt/hostedtoolcache/node/20.20.0/x64/bin/node node /home/REDACTED/work/github-copilot-token-usage/github-copilot-token-usage/node_modules/.bin/vscode-test(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.