sm#317: event stream contract + schema version pinning for interactive CLI#2
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf4056915b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c0f8ccc87c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04eb16d96c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…e CLI (#2) * feat: add interactive event stream contract and schema pinning * fix: address codex review feedback for event stream contract * fix: restore terminal on logger init failure and guard stdout stream mode * fix: make stdio event stream mode reachable without TUI output corruption
- Remove numeric prefixes for disabled rows in shared list rendering. These numbers are shortcuts, Ex: Pressing "2" selects option `#2`. Disabled items can not be selected, so keeping numbers on these items is misleading. - Apply the same behavior in both tui and tui_app_server. - Update affected snapshots for apps/plugins loading and plugin detail rows. _**This is a global change.**_ Before: <img width="1680" height="488" alt="image" src="https://github.com/user-attachments/assets/4bcf94ad-285f-48d3-a235-a85b58ee58e2" /> After: <img width="1706" height="484" alt="image" src="https://github.com/user-attachments/assets/76bb6107-a562-42fe-ae94-29440447ca77" />
…e CLI (#2) * feat: add interactive event stream contract and schema pinning * fix: address codex review feedback for event stream contract * fix: restore terminal on logger init failure and guard stdout stream mode * fix: make stdio event stream mode reachable without TUI output corruption
1 participant
Implements ticket A from session-manager epic openai#316 (session-manager#317).
Changes
--event-streamand--event-schema-version1and2with explicit validation and pinningschema_version,ts,session_id,event_type,payload)seq,session_epoch) in v2docs/event-stream-contract.mdFixtures
codex-rs/tui/tests/fixtures/event_stream/v1_turn_started.jsoncodex-rs/tui/tests/fixtures/event_stream/v2_turn_started.json