Resolve and install transitive registryDependencies for registry items#3
Merged
rakibulism merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f18c14cc7a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
registryDependenciesand the CLI needs to fetch and install those transitive dependencies before installing the requested item.addflow must remap targets and install dependencies in topological order so projects get all required files without manual steps.Description
resolveItemWithDependenciesto the registry resolver to fetch an item and all transitiveregistryDependenciesin topological order and detect cycles, and keptresolveItemas a thin wrapper around it.runAddto callresolveItemWithDependencies, remap targets for every resolved item, install each dependency item before the requested item, and return aninstalledlist in the result along with accumulatedwrittenfiles.resolveItemWithDependenciesfrom the registry index and updated imports in theaddcommand to use it instead ofresolveItem.add.test.tsto expect dependency installation and updatedregistry/resolver.test.tsto test dependency ordering, missing transitive dependency errors, and cycle detection; adjusted mocked fetch and fixture items to simulateregistryDependencies.Testing
packages/cli/src/registry/resolver.test.tswhich exerciselistRegistryItems,resolveItem, and the newresolveItemWithDependenciescases for ordering, missing dependency, and cycles, and they passed.packages/cli/src/commands/add.test.tswhich verify remapped targets, dependency installs, and snippet behavior, and they passed.Codex Task