Skip to content

Conversation

@jacobmealey
Copy link
Contributor

This patch comes from the downstream debian and was authored by Andreas Beckmann anbe@debian.org here:

https://salsa.debian.org/debian/rc/-/blob/main/debian/patches/gcc-15.patch?ref_type=heads

Fixes #113

@rakitzis
Copy link
Owner

Hi Jacob, thanks for this patch. It looks good but the sense of the #ifdef means that for environments where __STDC_VERSION__ is undefined (ancient C compilers?) the #else clause will not be active. Could you reverse the sense of the conditional? This way backward compatibility is ensured. Thanks.

(From Google: __STDC_VERSION__ appeared in C94. I'm curious to know whether rc still compiles with C89 but I have no reason to expect it doesn't.)

@jacobmealey jacobmealey force-pushed the master branch 2 times, most recently from 9dda781 to 9d5c17b Compare September 29, 2025 10:58
This patch comes from the downstream debian and was
authored by Andreas Beckmann <anbe@debian.org> here:

https://salsa.debian.org/debian/rc/-/blob/main/debian/patches/gcc-15.patch?ref_type=heads

Fixes rakitzis#113
@jacobmealey
Copy link
Contributor Author

Hello, that was a good catch. sorry for the spamming of force pushes. I thought I found a wierd case that required extra preprocessor logic, but then i realised it was reduntent.

Also i've compiled this with c89 and c99 and it seems happy, but that was just with gcc.

@rakitzis
Copy link
Owner

rakitzis commented Oct 1, 2025

Thanks!

@rakitzis rakitzis merged commit 2bab312 into rakitzis:master Oct 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Building using GCC 15 (C23) fails related to bools

2 participants