Skip to content

Replace Perl with Raku#29

Merged
JJ merged 4 commits intorakudo:masterfrom
paultcochrane:replace-perl-with-raku
Jul 31, 2020
Merged

Replace Perl with Raku#29
JJ merged 4 commits intorakudo:masterfrom
paultcochrane:replace-perl-with-raku

Conversation

@paultcochrane
Copy link
Contributor

While reading the README files, I noticed situations where Perl or Perl 6 or p6 were used instead of the relevant Raku equivalent. This PR updates the README files to use the new name. The PR is split into several commits so that they can be cherry-picked if so desired. If you want any changes made to this PR, please let me know and I'll be happy to update and resubmit as necessary.

And simplify the statement, as "Rakudo Perl 6" is no longer accurate.
@paultcochrane paultcochrane requested a review from moritz July 31, 2020 10:46
Copy link
Contributor

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, please check if the Travis URL works.


[![Build Status](https://travis-ci.org/raku/docker.svg?branch=master)](https://travis-ci.org/perl6/docker)
[![Build Status](https://travis-ci.org/raku/docker.svg?branch=master)](https://travis-ci.org/raku/docker)

Copy link
Contributor

@JJ JJ Jul 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please capitalize? It's probably OK, but it's better if it's got the same URL as this repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I've just pushed an update to the PR.

@paultcochrane
Copy link
Contributor Author

Thanks a lot, please check if the Travis URL works.

Actually I did, and it does work, however you're right, the capitalised version would be better. I'll update the commit and force-push the changes.

The `perl6` docker project no longer exists since it has been moved
under the `raku` organisation.
@paultcochrane paultcochrane force-pushed the replace-perl-with-raku branch from 36c7584 to 7fa5b44 Compare July 31, 2020 10:54
@JJ JJ merged commit 75c4cb0 into rakudo:master Jul 31, 2020
@paultcochrane
Copy link
Contributor Author

Unfortunately, one of the Travis builds failed. It looks like something weird is happening with key signing step. This is also causing builds of a new PR to fail completely. Any idea what's going on here? Error details are:

+ gpg --batch --keyserver ha.pool.sks-keyservers.net --recv-keys ECF8B611205B447E091246AF959E3D6197190DD5 7A6C9EB8809CFEAF0ED4E09F18C438E6FF24326D B6F697742EFCAF5F23CE51D5031D65902E840821

gpg: keybox '/tmp/tmp.6REZTLsgQI/pubring.kbx' created

gpg: /tmp/tmp.6REZTLsgQI/trustdb.gpg: trustdb created

gpg: key 7A6AC285E2D98827: public key "Patrick Spek <p.spek@tyil.nl>" imported

gpg: key 18C438E6FF24326D: public key "Naoum Hankache <naoum88@gmail.com>" imported

gpg: key 959E3D6197190DD5: 1 duplicate signature removed

gpg: key 959E3D6197190DD5: 2 bad signatures

gpg: key 959E3D6197190DD5: no user ID for key signature packet of class 13

gpg: key 959E3D6197190DD5: no user ID for signature

gpg: Total number processed: 3

gpg:               imported: 2

The command '/bin/sh -c buildDeps='         gcc         libc6-dev         libencode-perl         make     '         url="https://rakudo.org/dl/star/rakudo-star-${rakudo_version}.tar.gz"     keyserver='ha.pool.sks-keyservers.net'     keyfp='ECF8B611205B447E091246AF959E3D6197190DD5 7A6C9EB8809CFEAF0ED4E09F18C438E6FF24326D B6F697742EFCAF5F23CE51D5031D65902E840821'     tmpdir="$(mktemp -d)"     && set -x     && export GNUPGHOME="$tmpdir"     && apt-get update     && apt-get --yes install --no-install-recommends $buildDeps     && rm -rf /var/lib/apt/lists/*     && mkdir ${tmpdir}/rakudo         && curl -fsSL ${url}.asc -o ${tmpdir}/rakudo.tar.gz.asc     && curl -fsSL $url -o ${tmpdir}/rakudo.tar.gz     && gpg --batch --keyserver $keyserver --recv-keys $keyfp     && gpg --batch --verify ${tmpdir}/rakudo.tar.gz.asc ${tmpdir}/rakudo.tar.gz         && tar xzf ${tmpdir}/rakudo.tar.gz --strip-components=1 -C ${tmpdir}/rakudo     && (         cd ${tmpdir}/rakudo         && perl Configure.pl --prefix=/usr --gen-moar         && make install     )     && rm -rf $tmpdir     && apt-get purge -y --auto-remove $buildDeps' returned a non-zero code: 2

The command "docker build -t rakudo-star $DOCKERFILE_LOCATION" exited with 2.

@JJ
Copy link
Contributor

JJ commented Jul 31, 2020

Baffling...

@JJ
Copy link
Contributor

JJ commented Jul 31, 2020

Would need to test locally. It includes something called "hack-my-build.sh" so who knows...

@zakame
Copy link
Contributor

zakame commented Jul 31, 2020

hack-my-build.sh came from #21, perhaps this is due for refactoring for https://github.com/Raku/docker/blob/75c4cb06dd217448d2c9622249b48992fb9e18c2/Dockerfile#L18

(e.g. HA keyservers aren't really highly-available...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants