fix portability issue #41
Merged
+27
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xms0g
commented
Feb 3, 2026
xms0g
commented
- added missing headers.
- m128i_u32 is MSVC specific so compiling fails on clang. Exchanged with _mm_extract_epi32.
…back to prevent extra-copied object
…SE/AVX intrinsics
ran-j
reviewed
Feb 3, 2026
| #include <unistd.h> | ||
| #endif | ||
|
|
||
| #include "libdwarf_private.h" |
Contributor
Author
There was a problem hiding this comment.
const int siblingResult = dwarf_siblingof_b(dbg, current, TRUE, &sibling, &error);
TRUE is not recognizable here. Fails on MacOS, probably on Linux. where does TRUE macro come from?
|
tested under linux mint -> ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.