add ML-DSA certificate tests with certificates from RFC 9881#5317
Open
falko-strenzke wants to merge 10 commits intomasterfrom
Open
add ML-DSA certificate tests with certificates from RFC 9881#5317falko-strenzke wants to merge 10 commits intomasterfrom
falko-strenzke wants to merge 10 commits intomasterfrom
Conversation
reneme
approved these changes
Feb 12, 2026
Collaborator
reneme
left a comment
reneme
left a comment
There was a problem hiding this comment.
Nice! Please rebase to latest master to fix the merge conflict and consider the minor comment. Otherwise this looks good to me.
clang-tidy might have some opinions regarding const declarations, though.
src/tests/test_dilithium.cpp
Outdated
| @@ -9,16 +9,18 @@ | |||
| * Botan is released under the Simplified BSD License (see license.txt) | |||
| */ | |||
|
|
|||
| #include "botan/pkix_enums.h" | |||
Collaborator
There was a problem hiding this comment.
Please move this into the #if defined(BOTAN_HAS_DILITHIUM_COMMON) for consistency and use angle brackets instead of quotes.
falko-strenzke
force-pushed
the
mldsa-cert-test-rfc9881
branch
from
77a7b65 to
b404f04
Compare
Owner
|
CI failures are relevant |
falko-strenzke
force-pushed
the
mldsa-cert-test-rfc9881
branch
from
bdb2659 to
e3285b7
Compare
Collaborator
Author
|
@randombit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.