Remove unused test vector parameters in bitvector test#5331
Merged
reneme merged 1 commit intorandombit:masterfrom Feb 16, 2026
Merged
Conversation
reneme
approved these changes
Feb 16, 2026
Collaborator
reneme
left a comment
reneme
left a comment
There was a problem hiding this comment.
Eagle eyes! Yeah, absolutely. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR contains the removal of unnecessary test parameters. I noticed this today.
check_set()iterates overbits[0..size()-1]. The expected set of 20 values was never visited because both the lhs and rhs are 20-bit vectors (valid indices: 0..19), and this expectation was silently skipped without being tested. The correct OR result of the two operands is{0,1,4,15,16,17,18}.I don't think this will have any negative effects. It's just more correct for it not to exist at all than for it to be silently skipped.
Regards.