Remove confirm test helper, use test_is_true or test_is_false instead#5334
Merged
Remove confirm test helper, use test_is_true or test_is_false instead#5334
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request removes the deprecated confirm test helper method and replaces all its usages with either test_is_true or test_is_false throughout the Botan test suite. The change improves consistency by using the more explicit test assertion methods.
Changes:
- Removed the
confirmmethod fromTest::Resultclass intests.h - Updated
tests.cppto usetest_bool_eqinstead ofconfirmin therequiremethod - Replaced all
confirmcalls withtest_is_trueortest_is_falseacross numerous test files
Reviewed changes
Copilot reviewed 74 out of 74 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/tests.h | Removed confirm method definition and updated example documentation |
| src/tests/tests.cpp | Changed require to use test_bool_eq instead of confirm |
| src/tests/unit_x509.cpp | Replaced confirm with test_is_true, test_is_false, and test_not_null |
| src/tests/unit_tls_policy.cpp | Replaced confirm with test_is_true |
| src/tests/unit_tls.cpp | Replaced confirm with test_is_true and test_is_false |
| src/tests/unit_ecdsa.cpp | Replaced confirm with test_is_true |
| src/tests/unit_asio_stream.cpp | Replaced confirm with test_is_true |
| src/tests/test_*.cpp (numerous files) | Replaced confirm with test_is_true and test_is_false |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.