IWYU - Clean up unused includes and forward declarations#5350
Draft
KaganCanSit wants to merge 1 commit intorandombit:masterfrom
Draft
IWYU - Clean up unused includes and forward declarations#5350KaganCanSit wants to merge 1 commit intorandombit:masterfrom
KaganCanSit wants to merge 1 commit intorandombit:masterfrom
Conversation
d4af290 to
cc6ba53
Compare
Contributor
Author
|
Hit by #5382, rebase to master branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I am aware that improving the project's compilation time and cleanliness is currently a high priority. With the help of IWYU, I have identified some points. I hope this helps.
Frankly, I'm not sure about some points. I'll mark them as draft. (wmmintrin/immintrin)
Changes:
<wmmintrin.h>with<immintrin.h>in aes_vaes.cpp (covers VAES 256-bit intrinsics)<immintrin.h>with<emmintrin.h>in zfec_sse2.cpp (SSE2-only module)<cstdint>includes wherebotan/types.hprovides coverage<memory>,<string>,<algorithm>,<cstddef>includesI didn't encounter any errors during compilation and testing in the Linux environment, but I will look at the CI. Additionally, if there is any point you would like me to revise, please leave a comment and I will look into it.
Regards.
Note: Additionally, I saw the following warnings. It compiles when I make changes, but I didn't want to add them because I wasn't sure.