Allow entity-particles to be built on JitPack#2
Merged
randombyte-developer merged 1 commit intorandombyte-developer:masterfrom Jul 16, 2018
Merged
Conversation
This commits makes two changes: * Only enable the prompsign plugin when not on JitPack * Make the maven 'install' task depedent on shadowJar, to ensure that shadowing happens properly when JitPack runs './gradlew install'
Owner
|
The same as with ByteItems, though I think based on #1 that you are trying to include this plugin somehow in a |
Contributor
Author
|
I'm adding a integration with PixelmonPlaceholders. At dev time, having a shaded jar available allows me to easily run PixelmonPlaceholders from my IDE. Otherwise, I need to temporarily remove the dependency from Intellij's settings and download |
Owner
|
Ok |
randombyte-developer
added a commit
that referenced
this pull request
Jul 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commits makes two changes:
shadowing happens properly when JitPack runs './gradlew install'