forked from anomalyco/opencode
-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Context
Code review of feature/taskctl-pipeline noted that Pulse tests cover basic scheduling and staging but are missing edge cases for the more complex failure scenarios.
Missing test coverage
Tick concurrency
- What happens if a tick takes > 10 seconds (the overlap guard)? Verify the tick is skipped, not queued
- What if
processAdversarialVerdictsthrows mid-loop? Does the lock clean up?
Lock file corruption
- Lock file exists with non-numeric content →
readLockPidreturns null correctly - Lock file exists with PID of dead process → treated as zombie correctly in
resume
Session resurrection edge cases
- Task in
in_progresswith worktree that no longer exists → resurrection handles missing worktree gracefully - Task in
adversarial-runningwith dead session → 60-min timeout transitions toreviewing
Completion edge cases
- Job with mix of closed + failed tasks → completion check correctly waits (not all closed)
- Job with zero tasks → completion fires immediately
Acceptance criteria
- At least 6 new meaningful tests covering the above scenarios
-
bun test test/tasks/pulse.test.tspasses with 0 failures -
bun run typecheckpasses with 0 errors
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request