Skip to content

Update dependencies and checkstyle plugin#12

Merged
gschneider-r7 merged 1 commit intomasterfrom
update-deps
Oct 6, 2021
Merged

Update dependencies and checkstyle plugin#12
gschneider-r7 merged 1 commit intomasterfrom
update-deps

Conversation

@gschneider-r7
Copy link
Copy Markdown
Contributor

@gschneider-r7 gschneider-r7 commented Oct 6, 2021

Description

Updates dependencies and checkstyle plugin to use latest versions.

Updates the google_checks.xml file to accommodate checkstyle changes. Some fields are no longer supported, others were moved to the new MissingJavadocMethod module.

Motivation and Context

There are a couple lingering dependabot PRs and most of the dependencies are test-only, so it made sense to just upgrade everything to latest versions.

How Has This Been Tested?

Ran mvn clean install locally and verified that:

  • Checkstyle is running on each module correctly
  • All tests pass

Not tested: Checkstyle plugins for IDEs like Eclipse, Intellij, VS Code, etc.
It's possible that these plugins may not be compatible with the latest checkstyle version.

Types of changes

  • non-breaking dependency changes
  • breaking checkstyle change

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@mkienow-r7
Copy link
Copy Markdown
Contributor

mkienow-r7 commented Oct 6, 2021

mvn clean install worked without issue, however, I'm seeing the following error when attempting to use the IntelliJ IDEA CheckStyle-IDEA plugin (version 5.56.0).

The Checkstyle rules file could not be parsed.
cannot initialize module TreeWalker - cannot initialize module JavadocMethod - Property 'accessModifiers' does not exist, please check the documentation

@mkienow-r7
Copy link
Copy Markdown
Contributor

I updated the plugin settings to use checkstyle version 9.0 and the rules were parsed correctly.

Copy link
Copy Markdown
Contributor

@mkienow-r7 mkienow-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gschneider-r7 gschneider-r7 merged commit b14da27 into master Oct 6, 2021
@gschneider-r7 gschneider-r7 deleted the update-deps branch October 6, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants