Update dependencies and checkstyle plugin#12
Merged
gschneider-r7 merged 1 commit intomasterfrom Oct 6, 2021
Merged
Conversation
Use latest versions
Contributor
|
|
Contributor
|
I updated the plugin settings to use checkstyle version 9.0 and the rules were parsed correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates dependencies and checkstyle plugin to use latest versions.
Updates the
google_checks.xmlfile to accommodate checkstyle changes. Some fields are no longer supported, others were moved to the newMissingJavadocMethodmodule.Motivation and Context
There are a couple lingering dependabot PRs and most of the dependencies are test-only, so it made sense to just upgrade everything to latest versions.
How Has This Been Tested?
Ran
mvn clean installlocally and verified that:Not tested: Checkstyle plugins for IDEs like Eclipse, Intellij, VS Code, etc.
It's possible that these plugins may not be compatible with the latest checkstyle version.
Types of changes
Checklist: