Modify recog verify tool to better match Ruby implementation output#14
Merged
mkienow-r7 merged 2 commits intorapid7:masterfrom Nov 3, 2021
Merged
Conversation
This makes it easier to compare output against the Ruby implementation.
gschneider-r7
approved these changes
Nov 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small modifications were made to the recog verify tool to better match the Ruby implementation output. The message order did not match the Ruby implementation since Ruby's hash maintains insertion order. In order to resolve this the following changes were made:
HashMapreplaced withLinkedHashMapHashSetreplaced withLinkedHashSetdescriptionfieldMotivation and Context
This makes it easier to compare output against the Ruby implementation.
How Has This Been Tested?
mvn integration-testrecog_verifyoutput to thecom.rapid7.recog.verify.RecogVerifieroutput. Of the 49 XML fingerprint files from rapid7/recog only 3 created differences and those were the result of the Java implementation not currently supporting base64 encoding. The three files with differences were:ldap_searchresult.xml,snmp_sysdescr.xml, andtelnet_banners.xml.Types of changes
Checklist: