Add support for base64 encoded examples#15
Merged
mkienow-r7 merged 3 commits intorapid7:masterfrom Nov 12, 2021
Merged
Conversation
These changes helped to resolve most issues discovered when testing base64 encoded examples.
gschneider-r7
approved these changes
Nov 4, 2021
This was referenced Nov 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for base64 encoded examples.
Motivation and Context
Increases feature parity with other recog language implementations.
How Has This Been Tested?
mvn clean install -DskipITsmvn integration-test- this will fail until thexml/telnet_banners.xmlchanges are landed in rapid7/recog and available via Ruby Gemscom.rapid7.recog.verify.RecogVerifiertool no longer reports failures in any of the 49 XML fingerprint files from the modified rapid7/recog branch.Types of changes
Checklist: