Skip to content

Add support for external example files#16

Merged
mkienow-r7 merged 3 commits intorapid7:masterfrom
mkienow-r7:feature/support-external-example-files
Nov 15, 2021
Merged

Add support for external example files#16
mkienow-r7 merged 3 commits intorapid7:masterfrom
mkienow-r7:feature/support-external-example-files

Conversation

@mkienow-r7
Copy link
Copy Markdown
Contributor

@mkienow-r7 mkienow-r7 commented Nov 12, 2021

Description

Adds support for external example files.

Motivation and Context

Increases feature parity with other recog language implementations. rapid7/recog#382 introduced this feature into the Ruby language implementation.

How Has This Been Tested?

  • New unit tests
  • mvn clean install -DskipITs
  • mvn integration-test - this will fail until the xml/telnet_banners.xml changes are landed in rapid7/recog and available via Ruby Gems
  • The com.rapid7.recog.verify.RecogVerifier tool with local fingerprints using external example files. These fingerprints included a subset from xml/ldap_searchresult.xml where the base64 example data was decoded into external example files.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@mkienow-r7 mkienow-r7 force-pushed the feature/support-external-example-files branch from df563d3 to 206b5e9 Compare November 12, 2021 18:04
@mkienow-r7 mkienow-r7 force-pushed the feature/support-external-example-files branch from 206b5e9 to e9ed3bb Compare November 12, 2021 18:55
@mkienow-r7 mkienow-r7 merged commit d9d42bd into rapid7:master Nov 15, 2021
@mkienow-r7 mkienow-r7 deleted the feature/support-external-example-files branch November 15, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants