Skip to content

Sync with recog/#402: Reduce warning output when no tests are present #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkienow-r7 merged 2 commits into from
Jan 28, 2022
Merged

Sync with recog/#402: Reduce warning output when no tests are present #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5232fa
Bump recog content to version 2.3.22
dabdine Jan 27, 2022
b7cb549
Sync with rapid7/recog#402: Reduce warning output when no tests are p…
dabdine Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
</distributionManagement>

<properties>
<r7.recog.content.version>2.3.21</r7.recog.content.version>
<r7.recog.content.version>2.3.22</r7.recog.content.version>
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
Expand Down
2 changes: 1 addition & 1 deletion recog-verify/src/test/java/com/rapid7/recog/verify/RecogVerifierTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public void verifyNoExampleNonZeroPositionParamsWarnCount() throws ParseExceptio
// then
assertEquals(0, verifier.getReporter().getSuccessCount());
assertEquals(0, verifier.getReporter().getFailureCount());
assertEquals(4, verifier.getReporter().getWarningCount());
assertEquals(1, verifier.getReporter().getWarningCount());
}

@Test
Expand Down
1 change: 1 addition & 0 deletions recog/src/main/java/com/rapid7/recog/RecogMatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ public void verifyExamples(BiConsumer<VerifyStatus, String> consumer) {
// look for the presence of test cases
if (examples.size() == 0) {
consumer.accept(VerifyStatus.Warn, String.format("'%s' has no test cases", description));
return;
}

// make sure each test case passes
Expand Down