Fix multimodule checkstyle configuration#21
Merged
mkienow-r7 merged 1 commit intorapid7:masterfrom May 20, 2022
Merged
Conversation
gschneider-r7
approved these changes
May 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the multimodule checkstyle configuration which currently relies on the private and undocumented 12 property
maven.multiModuleProjectDirectory. This follows the Apache Maven Checkstyle Plugin example for a Multimodule Configuration.Motivation and Context
The solution using
maven.multiModuleProjectDirectoryis not stable given it relies on a private and undocumented property limited to Maven versions 3.3.1 and greater. In addition, the current configuration fails to build successfully on the build server.How Has This Been Tested?
mvn clean installbuild-tools/src/main/resources/recog-java/google_checks.xmland java source to introduce a checkstyle error. Ranmvn clean installand confirmed checkstyle error.Types of changes
Checklist:
Footnotes
MNG-6589 - Document property maven.multiModuleProjectDirectory ↩
MNG-7038 - Introduce public property to point to a root directory of (multi-module) project ↩