Add handling and documentation for temporary params in fingerprints#12
Merged
mkienow-r7 merged 4 commits intorapid7:mainfrom Mar 16, 2023
Merged
Add handling and documentation for temporary params in fingerprints#12mkienow-r7 merged 4 commits intorapid7:mainfrom
mkienow-r7 merged 4 commits intorapid7:mainfrom
Conversation
TomSellers
commented
Feb 23, 2023
TomSellers
commented
Feb 23, 2023
TomSellers
commented
Feb 23, 2023
| </fingerprint> | ||
| ``` | ||
|
|
||
| There is special handling for temporary `name` attributes starting with `_tmp.` such |
Contributor
Author
There was a problem hiding this comment.
New content related to _tmp. here.
mkienow-r7
suggested changes
Feb 28, 2023
This was referenced Mar 2, 2023
mkienow-r7
reviewed
Mar 3, 2023
| There is special handling for temporary attributes that have a name starting with | ||
| `_tmp.`. These attributes can be used for interpolation but are not emitted in the | ||
| output. This is useful when a particular product name is inconsistent in various | ||
| banners, vendor marketing, or with NIST values when trying to generated CPEs. In |
Contributor
Author
There was a problem hiding this comment.
Fixed, thanks for catching.
mkienow-r7
approved these changes
Mar 16, 2023
Contributor
mkienow-r7
left a comment
mkienow-r7
left a comment
There was a problem hiding this comment.
Thank you for the contribution @TomSellers!
mkienow-r7
added a commit
to rapid7/recog
that referenced
this pull request
Mar 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds handling and documentation for temporary params (
_tmp.*) in fingerprints. The explanationis handled in the README. Let me know if it isn't clear and I will adjust. I discussed this with @mkienow-r7 late
last month.
I've also opened rapid7/recog#547 to mirror the documentation changes there.
How Has This Been Tested?
Local tests, forked implementation.
Types of changes
Checklist: