http_servers: fix incorrect IP regex#353
Merged
tsellers-r7 merged 2 commits intorapid7:masterfrom Apr 29, 2021
Merged
Conversation
gschneider-r7
approved these changes
Apr 29, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR corrects a regex used for IPv4 addresses used in
http_servers.xml. The regex failed to escape a.and could DoS the parser when processing very long numeric sequences.The PR correctly escapes the period and limits the number of repeating digits allowed before the match fails.
This issue was highlighted in a PR to
recog-javahere: rapid7/recog-java#7Motivation and Context
Bug fix, performance improvement
How Has This Been Tested?
rspecwith built inexampletests. I have also tested the regex with Go and Rust online regex testers. Both of these languages use the RE2 engine by default.Types of changes
Checklist: