Eliminate warnings when no examples are present in fingerprints#402
Merged
mkienow-r7 merged 2 commits intorapid7:masterfrom Jan 28, 2022
Merged
Conversation
Contributor
|
I appreciate the output being free of the spurious warnings. Thank you for the contribution @dabdine! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A simple change to eliminate spurious warnings produced by Ruby
recog_verifywhen no examples are present. In other words, instead of emitting these warnings:The code will now emit:
For this fingerprint:
It will still emit the "checks for parameter" warnings when it should, however. For example, in the case where there's a legitimate missing attribute:
You'll get:
Motivation and Context
This clutters
recog_verifyoutput unnecessarily. As there are no examples to begin with, there's no point in mentioning whether any attributes aren't tested.How Has This Been Tested?
recog_verifybundle exec rake testsTypes of changes
Checklist: