Skip to content

Removing dependency from docs build#44

Closed
acostadon wants to merge 4 commits intorapidsai:branch-24.08from
acostadon:ci_add
Closed

Removing dependency from docs build#44
acostadon wants to merge 4 commits intorapidsai:branch-24.08from
acostadon:ci_add

Conversation

@acostadon
Copy link
Copy Markdown
Contributor

No description provided.

@acostadon acostadon requested a review from a team as a code owner September 16, 2024 18:19
@acostadon acostadon requested review from jameslamb and removed request for a team September 16, 2024 18:19
Copy link
Copy Markdown
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, as this repo is using already-published cugraph packages and doesn't have CI to build them.

But in that case, lines like this in CI scripts should be removed too:

CPP_CHANNEL=$(rapids-download-conda-from-s3 cpp)
PYTHON_CHANNEL=$(rapids-download-conda-from-s3 python)

Also... should there be a branch-24.10 branch created here, and should PRs like this one target that instead?

Comment thread .github/ops-bot.yaml
label_checker: true
release_drafter: false
recently_updated: true
forward_merger: false
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ops-bot.yaml file will be necessary to get RAPIDS CI running on the repo.

I think some additional manual steps will need to be done by ops to enable it https://github.com/rapidsai/ops/issues/3424

Comment thread ci/build_docs.sh
"cugraph-dgl=${RAPIDS_VERSION_MAJOR_MINOR}.*" \
"libcugraph_etl=${RAPIDS_VERSION_MAJOR_MINOR}.*" \
"pylibcugraphops=${RAPIDS_VERSION_MAJOR_MINOR}.*" \
"pylibwholegraph=${RAPIDS_VERSION_MAJOR_MINOR}.*" \
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding these versions to be sure that building the docs from an older branch pulls in the correct versions of all the cugraph libraries, instead of whatever happens to be the latest versions at the moment you run the build.

@jameslamb jameslamb mentioned this pull request Sep 16, 2024
@acostadon acostadon closed this by deleting the head repository Sep 18, 2024
rapids-bot Bot pushed a commit that referenced this pull request Dec 18, 2024
Replaces #44.

Trying a new PR that enables docs builds on PRs and branch builds.

Authors:
  - James Lamb (https://github.com/jameslamb)
  - Brad Rees (https://github.com/BradReesWork)
  - Jake Awe (https://github.com/AyodeAwe)

Approvers:
  - Don Acosta (https://github.com/acostadon)
  - Mike Sarahan (https://github.com/msarahan)

URL: #46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants