[REVIEW] Enhance compile time#1267
Merged
BradReesWork merged 17 commits intorapidsai:branch-0.17from Nov 23, 2020
Merged
Conversation
forked 0.16 <- release 0.16
Forked branch-0.16 updated from Release branch-0.16
Update fork from release 0.17
merge latest 0.17
Contributor
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #1267 +/- ##
===============================================
+ Coverage 57.84% 57.92% +0.08%
===============================================
Files 63 65 +2
Lines 2780 2800 +20
===============================================
+ Hits 1608 1622 +14
- Misses 1172 1178 +6
Continue to review full report at Codecov.
|
BradReesWork
added
the
improvement
rlratzel
requested changes
Nov 20, 2020
rlratzel
approved these changes
Nov 21, 2020
Collaborator
Author
|
Rerun tests. |
ajschmidt8
approved these changes
Nov 23, 2020
ChuckHastings
requested changes
Nov 23, 2020
Collaborator
ChuckHastings
left a comment
ChuckHastings
left a comment
There was a problem hiding this comment.
A few things I think we should consider excluding. Otherwise I can't wait to have this merged.
5 tasks
…efault cnstr in graph.
ChuckHastings
approved these changes
Nov 23, 2020
BradReesWork
approved these changes
Nov 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Look into alternative ways to instantiate templates to improve compilation time.